After watching 0lhi's videos, I have one small idea why the almost whole second didn't count, it's a possible conditional mess, lemme to check...
EDIT: I Confirmed, that a bug, I forgot to put the stopwatch iteration code into the path waiter...
EDIT2: Fixed just now, @0lhi, please re-run the TheXTech test with an updated pull.
Issue 1: Is there a way to more accurately count this for XTech? Issue 2: Is there a way to make the key exit in SMBX2 to work more like the key exit in Xtech (Video Below), if that's not possible can you look at the other way Issue 3: Can you make the event name that the timer stops on something the player can choose?
Issue 1: Is there a way to more accurately count this for XTech? About the path waiter, that was a missing stopwatch iterator call, I fixed this just now. Are there are any other issues?
Issue 2: Is there a way to make the key exit in SMBX2 work more like the key exit in Xtech That a request to @Rednaxela, recently I explained to him about this mess through Discord. Optionally, I can make the same frames counting after keyhole as SMBX2 now (until Red will fix that), by adding 300 frames to the common time. However, here is the universal workaround for SMBX2 how to make the timer be fair after keyhole: When you do catch the WinCode as 3 (keyhole exit), pause the total stopwatch, and just add 195 frames into the total time.
Issue 3: Can you make the event name that the timer stops on something the player can choose? Recently I added the "Boss Dead" trigger that should do that work.
Get the fix and "Boss Dead" event hook support, wait until this build will complete: https://github.com/Wohlstand/TheXTech/actions/runs/553063476
EDIT3: Sorry, the @Rednaxela I had mentioned, probably is not Rednaxela we know: he lives in the USA, not in England. Sorry for the confusion.
@0lhi Can you give me a link to the latest build again, lost it in the thread.
@Wohlstand The newest build should fix issues 1 and 3 right?
smbx-win64.exe -m -p --speed-run-mode 2 --speed-run-semitransparent
The newest build should fix issues 1 and 3 right?
Yes! Issue 1 (accuracy) and 3 ("Boss Dead" event to stop the stopwatch without game end).
The 2 (keyhole) is the issue of SMBX2, I had to suggest a workaround for that.
Can you give me a link to the latest build again, lost it in the thread. It's here: https://builds.wohlsoft.ru/win32/thextech-super-mario-bros-x-win64-dev.7z Be careful, do download it once the CI build will finish.
EDIT: Seems the build was completed, feel free to take this ;-)
tfw when I download the build a few seconds before it finishes
If you try to download the build while CI is working, here are the next risks:
- you'll just get the old version
- you'll get the damaged archive because it was uploaded by CI to the server partially
- the chance you'll get the valid archive of a new version if CI had finished its upload, but didn't finish the last clean-up processing and uploading of other archives
@Wohlstand Issue 3 is fixed. Give me a bit before I talk about issue 2 more
Perfect! If anything will be also, I'll check after the sleep, at my time zone is too late (4:19 AM at the moment I posted this).
Back, so I noticed through doing this that due to how the logic of how the Beta 3 timer vs Beta 4 timer worked, I had to remove two of my IL runs for Princess Cliche and Another Princess Cliche.
Beta 3 Timer had both timers end at Boss Dead Beta 4 Timer has IL timer end at Game End and Full Game Timer end at Boss Dead
Hey, for now so that @0lhi is able to do runs, is it possible we can have a Enable-Keyhole-Fix flag set to false for Mode 2 and Mode 3
Also can you contact @Rednaxela to respond in this thread if there's plans to apply the Xtech Keyhole Fix to SMBX2? I didn't even know he had a speedrun.com account
As Wohlstand said, the Rednaxela here is probably another person. I'm gonna write him in the Wohlsoft Forums.
P.S. Just now I made a quick fix:
- Making the "fix-keyhole-framerate" compat.ini option https://github.com/Wohlstand/TheXTech/commit/bda8d37a785c6d2e5444c2928f4c80609bc22dec which is true by default, but false while mode 2 and 3.
- Changed the count of keyhole frames to 192 as this is more accurate by Rednaxela's words
Feel free to test once this build will finish: https://github.com/Wohlstand/TheXTech/actions/runs/553554607
Once Rednaxela will fix the keyhole framerate at SMBX2, I'll make this option being false at Mode 3 only, or, if needed, I'll keep it always true.
